Search Implementation and Query Type #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| os.Stdout.Write(jsonData) | ||
| os.Stdout.WriteString("\n") | ||
|
|
||
| // build a seach query |
There was a problem hiding this comment.
@fujin looking for feedback on implementation:
There are 2 ways to search. One you create a query object and call Do() with a client, the other you call client.Search.Exec("index", "query") not 100% which way we want to go. I could leave the SearchQuery type and NewQuery, but add a new Search.Run( q SearchQuery) or something ? Sorta like attaching the method to the query, but It's not in line with how most of the rest of the api is done. Granted search is a bit unique in the api compared to other things.
* adds functionality to http.go for encoding querystrings * Consistency fis for JSONClass field name across the board (JsonClass) Sorry bout this, but it came up while i was thinkinga bout decoding the returned objects. I can bust it out if it's anoying * new search.go and examples implementing standard search
spheromak
added a commit
that referenced
this pull request
Oct 11, 2014
Search Implementation and Query Type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Add partial, and figure out which way we want to go with the search service
Do()vsExec()