Replace wildcards correctly in RoutePattern (#515)

context.go

@@ -93,7 +93,17 @@ func (x *Context) URLParam(key string) string {
 //   }
 func (x *Context) RoutePattern() string {
 	routePattern := strings.Join(x.RoutePatterns, "")
-	return strings.Replace(routePattern, "/*/", "/", -1)
+	return replaceWildcards(routePattern)
+}
+
+// replaceWildcards takes a route pattern and recursively replaces all
+// occurrences of "/*/" to "/".
+func replaceWildcards(p string) string {
+	if strings.Contains(p, "/*/") {
+		return replaceWildcards(strings.Replace(p, "/*/", "/", -1))
+	}
+
+	return p
 }
 
 // RouteContext returns chi's routing Context object from a

context_test.go

@@ -0,0 +1,78 @@
+package chi
+
+import "testing"
+
+// TestRoutePattern tests correct in-the-middle wildcard removals.
+// If user organizes a router like this:
+//
+// (router.go)
+// r.Route("/v1", func(r chi.Router) {
+// 	r.Mount("/resources", resourcesController{}.Router())
+// }
+//
+// (resources_controller.go)
+// r.Route("/", func(r chi.Router) {
+// 	r.Get("/{resource_id}", getResource())
+// 	other routes...
+// }
+//
+// This test checks how the route pattern is calculated
+// "/v1/resources/{resource_id}" (right)
+// "/v1/resources/*/{resource_id}" (wrong)
+func TestRoutePattern(t *testing.T) {
+	routePatterns := []string{
+		"/v1/*",
+		"/resources/*",
+		"/{resource_id}",
+	}
+
+	x := &Context{
+		RoutePatterns: routePatterns,
+	}
+
+	if p := x.RoutePattern(); p != "/v1/resources/{resource_id}" {
+		t.Fatal("unexpected route pattern: " + p)
+	}
+
+	x.RoutePatterns = []string{
+		"/v1/*",
+		"/resources/*",
+		// Additional wildcard, depending on the router structure of the user
+		"/*",
+		"/{resource_id}",
+	}
+
+	// Correctly removes in-the-middle wildcards instead of "/v1/resources/*/{resource_id}"
+	if p := x.RoutePattern(); p != "/v1/resources/{resource_id}" {
+		t.Fatal("unexpected route pattern: " + p)
+	}
+
+	x.RoutePatterns = []string{
+		"/v1/*",
+		"/resources/*",
+		// Even with many wildcards
+		"/*",
+		"/*",
+		"/*",
+		"/{resource_id}/*", // Keeping trailing wildcard
+	}
+
+	// Correctly removes in-the-middle wildcards instead of "/v1/resources/*/*/{resource_id}/*"
+	if p := x.RoutePattern(); p != "/v1/resources/{resource_id}/*" {
+		t.Fatal("unexpected route pattern: " + p)
+	}
+
+	x.RoutePatterns = []string{
+		"/v1/*",
+		"/resources/*",
+		// And respects asterisks as part of the paths
+		"/*special_path/*",
+		"/with_asterisks*/*",
+		"/{resource_id}",
+	}
+
+	// Correctly removes in-the-middle wildcards instead of "/v1/resourcesspecial_path/with_asterisks{resource_id}"
+	if p := x.RoutePattern(); p != "/v1/resources/*special_path/with_asterisks*/{resource_id}" {
+		t.Fatal("unexpected route pattern: " + p)
+	}
+}