WIP: fix for high CPU and memory usage #918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry, started working recently, cant find time and motivation for this |
|
Thanks @aadi-1024 |
|
sorry I wasn't any help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP!!
I further narrowed down the problem in #916 and turns out it only occurs when you have a Mount with "/" prefix and are trying to access an endpoint that does not exist, i.e. it should return 404. Instead it goes into an infinite loop and just keeps on increasing the memory and CPU usage.
This is my first time with such a project and I'm having quite the trouble getting hang of the codebase; while this does work it breaks a few tests related to URL Params. A bit of help would be really appreciated.