Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows SysProcAttr create new process group #61

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Windows SysProcAttr create new process group #61

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ead1c47
Add Windows SysProcAttr create new process group
ClintonCollins Apr 24, 2021
1d79e61
Merge branch 'go-cmd:master' into windows-new-process-groups
ClintonCollins Jan 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cmd_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,8 @@ func terminateProcess(pid int) error {
}

func setProcessGroupID(cmd *exec.Cmd) {
cmd.SysProcAttr = &syscall.SysProcAttr{}
// Set create new process group so the cmd and all its children become a new
// process group. This allows Stop to SIGTERM the cmd's process group
// without killing this process (i.e. this code here).
cmd.SysProcAttr = &syscall.SysProcAttr{CreationFlags: syscall.CREATE_NEW_PROCESS_GROUP}
}