-
-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] - Add Metrics For Jobs #317
Comments
I think having optionally enabled prometheus metrics could be a nice a feature to add. |
metrics collector (counter,summary...)should always track job's state. |
Yeah. It'd be nice to make the metrics an interface so we can implement with prometheus now and then later it could be implemented with influx and others. |
Please weigh in if you have input on what sort of metrics you'd like to see from gocron -> #417 (comment) |
I think it’d be ideal to use otel like https://github.com/open-telemetry/opentelemetry-go/blob/main/example/prometheus/main.go |
Agreed that we may use OTEL to export the inner tracing data since gocron is a library instead of a service. For the metrics like the Prometheus, should be exported by the user service itself, and you can request gocron to export the way to get the metric's value you want, like the number of scheduling jobs, and so on. |
If anyone is looking to work on implementing this, what I'd like to see is:
|
We can add prometheus metrics for job execution.Then outside monitor system can use these metrics to track jobs.
Maybe I can send a pr.
The text was updated successfully, but these errors were encountered: