Add metrics #655
Closed
Add metrics #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnRoesler
reviewed
Jan 10, 2024
JohnRoesler
reviewed
Jan 10, 2024
JohnRoesler
reviewed
Jan 10, 2024
JohnRoesler
reviewed
Jan 10, 2024
executor.go
Outdated
| @@ -23,6 +23,7 @@ type executor struct { | |||
| limitMode *limitModeConfig | |||
| elector Elector | |||
| locker Locker | |||
| monitorer Monitorer | |||
There was a problem hiding this comment.
Suggested change
| monitorer Monitorer | |
| monitor Monitor |
JohnRoesler
reviewed
Jan 10, 2024
metrics.go
Outdated
Comment on lines
19
to
20
| // Monitorer represents the interface to collect jobs metrics. | ||
| type Monitorer interface { |
There was a problem hiding this comment.
Can you make this just Monitor throughout?
Suggested change
| // Monitorer represents the interface to collect jobs metrics. | |
| type Monitorer interface { | |
| // Monitor represents the interface to collect jobs metrics. | |
| type Monitor interface { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Add interface for collect jobs execution metrics: counter, time elapsed
Which issue(s) does this PR fix/relate to?
Resolves #317
List any changes that modify/break current functionality
Have you included tests for your changes?
Yes, tests for counter was added
Did you document any new/modified functionality?
example_test.goREADME.mdNotes