add WaitForSchedule(s) funcs #162
Conversation
scheduler.go
Outdated
| // new jobs with the WaitForSchedule option as true. | ||
| // The jobs will not start immediately but rather will | ||
| // wait until their first scheduled interval. | ||
| func (s *Scheduler) WaitForSchedules() { |
There was a problem hiding this comment.
I think the users might think WaitForSchedules() and WaitForSchedule() have the same behavior. Because we have other methods like Second()-Seconds(), Minute()-Minutes() etc which in spite of being singular and plural have the same behavior.
The comments are clear enough, but maybe a different name for WaitForSchedules might be nice.
There was a problem hiding this comment.
sure. Thoughts on the name?
There was a problem hiding this comment.
WaitForSchedulesAllJobs()
There was a problem hiding this comment.
Sure. Or if the word "Hold" makes sense, they can both be changed to HoldJobTillFirstSchedule and HoldAllJobsTillFirstSchedule
There was a problem hiding this comment.
We could also skip the word "First" to make it shorter :P
There was a problem hiding this comment.
how about WaitForScheduleAll i pushed that, let me know
What does this do?
WaitForScheduleandWaitForSchedulesto allow setting per job or for all jobs to wait for the first scheduled run rather than running immediatelyNewJobmethod. There was no use for it to be exported as we don't accept a newly created job struct in any scheduler methods. alters the signature to handle the wait for interval logicWhich issue(s) does this PR fix/relate to?
#152
List any changes that modify/break current functionality
Have you included tests for your changes?
Did you document any new/modified functionality?
example_test.goREADME.mdNotes