Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow removing Jobs that match multiple tags #263

Merged

Conversation

calvinmclean
Copy link

What does this do?

This changes RemoveByTag to accept multiple tags to match. All tags must be matched by the Job to be removed.

Which issue(s) does this PR fix/relate to?

N/A

List any changes that modify/break current functionality

These changes should not break any current functionality because the function name is unchanged and variadic parameter allows one or more inputs.

Have you included tests for your changes?

Yes

Did you document any new/modified functionality?

  • Updated example_test.go
  • Updated README.md

Notes

If it would be better to rename the function to RemoveByTags, I can do that, but I didn't want to make a breaking change.

scheduler.go Outdated Show resolved Hide resolved
@JohnRoesler
Copy link
Contributor

Great contribution! Thank you so much!

Copy link
Contributor

@JohnRoesler JohnRoesler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🎉

@JohnRoesler JohnRoesler merged commit c3be44d into go-co-op:main Dec 4, 2021
@calvinmclean calvinmclean deleted the feature/remove-by-multiple-tags branch December 4, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants