Allow removing Jobs that match multiple tags #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnRoesler
reviewed
Dec 4, 2021
|
Great contribution! Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This changes
RemoveByTagto accept multiple tags to match. All tags must be matched by the Job to be removed.Which issue(s) does this PR fix/relate to?
N/A
List any changes that modify/break current functionality
These changes should not break any current functionality because the function name is unchanged and variadic parameter allows one or more inputs.
Have you included tests for your changes?
Yes
Did you document any new/modified functionality?
example_test.goREADME.mdNotes
If it would be better to rename the function to
RemoveByTags, I can do that, but I didn't want to make a breaking change.