add locker for distributed scheduling #463
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
adds the
WithDistributedLocker()
method to the scheduler that takes in a Locker allowing for locking jobs when multiple schedulers are running.The initial implementation is with redis. However, additional implementations may be added here via PR or you may simply implement your own Locker.
Which issue(s) does this PR fix/relate to?
#181
#180
List any changes that modify/break current functionality
Have you included tests for your changes?
yes
testcontainers will soon be officially supporting redis (it's not released, but is available on main) -> https://golang.testcontainers.org/modules/redis/
Super awesome project!
Did you document any new/modified functionality?
example_test.go
README.md
Notes
This is called out in the function docs for the new method, but I will post it here also: