fix: panic: runtime error: integer divide by zero #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Do" function triggers "doCommon" function that sets "inScheduleChain" to false. In "getCurrentJob", if "inScheduleChain" is false, then a new job will be added to a slice and the current job will be the last element of the slice. Therefore, after "Do" function runs, "StartAt" will try to obtain the current job. Since "inScheduleChain" is false, a new job with interval 0 will be added and returned as the current job in "StartAt" function. After this interval 0 will produce "duration" to be 0 and "panic: runtime error: integer divide by zero".
JohnRoesler
reviewed
Jun 1, 2023
Comment on lines
+761
to
+762
| _, _ = s.Every(5).Seconds().Do(task) | ||
| s.StartAt(time.Now().Add(10 * time.Second)) |
There was a problem hiding this comment.
Hi @BranislavLazic thanks for taking a stab at this. The solution you have here actually changes / breaks the design of the scheduling chain. The inScheduleChain bool is to prevent this type of activity as it causes more pain confusion to users not knowing which job exactly is being changed.
The chain is started anytime a method is called on the scheduler and terminated with Do is called.
The actual issue where a divide by zero can happen is when startAt is called and the time is in the past. I think just wrapping the potential divide by zero case in a check if the denominator is zero first will be the way to solve it. I'll open a PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Do" function triggers "doCommon" function that sets "inScheduleChain" to false. In "getCurrentJob", if "inScheduleChain" is false, then a new job will be added to a slice and the current job will be the last element of the slice. Therefore, after "Do" function runs, "StartAt" will try to obtain the current job. Since "inScheduleChain" is false, a new job with interval 0 will be added and returned as the current job in "StartAt" function. After this interval 0 will produce "duration" to be 0 and "panic: runtime error: integer divide by zero".
What does this do?
Which issue(s) does this PR fix/relate to?
Resolves #486
List any changes that modify/break current functionality
Have you included tests for your changes?
Yes
Did you document any new/modified functionality?
example_test.goREADME.mdNotes