fix: data race for get jobs map #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnRoesler
reviewed
Aug 31, 2023
| defer s.jobsMutex.RUnlock() | ||
| jobs := make(map[uuid.UUID]*Job, len(s.jobs)) | ||
| for id, job := range s.jobs { | ||
| jobs[id] = job |
There was a problem hiding this comment.
Is the data race on the map object or the jobs inside the map?
There was a problem hiding this comment.
😁 A coroutine calls the Jobs api to obtain jobs, and then reads them. Another coroutine modifies the jobs dictionary? In this way, golang will cause error messages for concurrent map reading and writing.
JohnRoesler
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
data race for get jobsMap.