Allow more time for requestJobCtx #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewgonzales360
commented
Mar 22, 2024
| @@ -44,18 +44,12 @@ func requestJob(id uuid.UUID, ch chan jobOutRequest) *internalJob { | |||
|
|
|||
| func requestJobCtx(ctx context.Context, id uuid.UUID, ch chan jobOutRequest) *internalJob { | |||
There was a problem hiding this comment.
IMO, this function should throw an error if the context deadline is exceeded instead of returning nil.
There was a problem hiding this comment.
yeah that seems reasonable. A context deadline exceeded error?
JohnRoesler
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
If you attempted to get a job and the channel was full, you were returned a
nil. Instead, this code will block and wait until a job is returned or the context deadline is exceeded.Which issue(s) does this PR fix/relate to?
#695
List any changes that modify/break current functionality
Have you included tests for your changes?
Yeah.
Did you document any new/modified functionality?
example_test.goREADME.mdNotes