issue-677: support task creation with variadic args #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnRoesler
reviewed
Jul 11, 2024
scheduler.go
Outdated
| @@ -535,6 +535,47 @@ func (s *scheduler) NewJob(jobDefinition JobDefinition, task Task, options ...Jo | |||
| return s.addOrUpdateJob(uuid.Nil, jobDefinition, task, options) | |||
| } | |||
|
|
|||
| func (s *scheduler) verifyParameterType(taskFunc reflect.Value, tsk task) error { | |||
| isVariadic := taskFunc.Type().IsVariadic() | |||
There was a problem hiding this comment.
🚀 epic, i was poking around the other day but didn't notice this IsVariadic method
JohnRoesler
reviewed
Jul 11, 2024
| }, | ||
| { | ||
| "all good no arguments passed in - variadic", | ||
| NewTask(func(args ...interface{}) {}), |
There was a problem hiding this comment.
could you add a test case with multiple argument types where the last one is variadic?
something like
NewTask(func(arg int, args ...string) {}, 1, "one", "two")There was a problem hiding this comment.
Sure this was neglected in my previous commit. And it's added now in this PR. Please have a look.
JohnRoesler
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This pull request implements variadic args support for task creation
Which issue(s) does this PR fix/relate to?
Resolves #677
List any changes that modify/break current functionality
Have you included tests for your changes?
I have added several cases in
scheduler_test.gobased on my changesDid you document any new/modified functionality?
scheduler_test.goNotes