checkers: fix typeUnparen for func type literals (#1262)

Fixes #1245
go-critic · Aug 28, 2022 · 9fd2b93 · 9fd2b93
1 parent a38bb6e
commit 9fd2b93
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/checkers/internal/astwalk/type_expr_walker.go b/checkers/internal/astwalk/type_expr_walker.go
@@ -97,7 +97,10 @@ func (w *typeExprWalker) walk(x ast.Node) bool {
 
 func (w *typeExprWalker) inspectInner(x ast.Expr) bool {
 	parens, ok := x.(*ast.ParenExpr)
-	if ok && typep.IsTypeExpr(w.info, parens.X) && astp.IsStarExpr(parens.X) {
+	shouldInspect := ok &&
+		typep.IsTypeExpr(w.info, parens.X) &&
+		(astp.IsStarExpr(parens.X) || astp.IsFuncType(parens.X))
+	if shouldInspect {
 		ast.Inspect(parens.X, w.walk)
 		return false
 	}

diff --git a/checkers/testdata/typeUnparen/negative_tests.go b/checkers/testdata/typeUnparen/negative_tests.go
@@ -96,3 +96,7 @@ func channelIssue1035() {
 	var _ chan (<-chan (chan int))
 	var _ chan (<-chan (<-chan int))
 }
+
+func funcIssue1245() {
+	_ = (func())(nil)
+}