checkers/httpNoBody: warn on using "nil" instead of "http.NoBody" on …

…(net/http/httptest).NewRequest (#1345)
go-critic · May 19, 2023 · d97daec · d97daec
1 parent 59f8a39
commit d97daec
Show file tree

Hide file tree

Showing 4 changed files with 669 additions and 643 deletions.
diff --git a/checkers/rules/rules.go b/checkers/rules/rules.go
@@ -89,6 +89,11 @@ func httpNoBody(m dsl.Matcher) {
 		Where(m["nil"].Text == "nil").
 		Suggest("http.NewRequestWithContext($ctx, $method, $url, http.NoBody)").
 		Report("http.NoBody should be preferred to the nil request body")
+
+	m.Match("httptest.NewRequest($method, $url, $nil)").
+		Where(m["nil"].Text == "nil").
+		Suggest("httptest.NewRequest($method, $url, http.NoBody)").
+		Report("http.NoBody should be preferred to the nil request body")
 }
 
 //doc:summary Detects expressions like []rune(s)[0] that may cause unwanted rune slice allocation