gocritic: ruleguard init error could not import github.com/quasilyte/go-ruleguard/dsl

[sebastien-rosset]

Symptom

When running ruleguard from golangci-lint, ruleguard is unable to import the github.com/quasilyte/go-ruleguard/dsl package. An error is returned.

Steps to reproduce

1. Install golangci-lint version 1.43.0
2. Execute golangci-lint -c golangci-lint.yaml run with gocritic/ruleguard enabled.
3. Notice the following error message is printed. None of the ruleguard rules are executed.

WARN [runner] Can't run linter goanalysis_metalinter: gocritic:
ruleguard init error: typechecker error: gorules/logging-rules.go:7:2:
could not import github.com/quasilyte/go-ruleguard/dsl
(can't find import: "github.com/quasilyte/go-ruleguard/dsl")

Environment

golangci-lint --version
golangci-lint has version 1.43.0 built from 861262b7 on 2021-11-03T11:57:46Z

golangci.yaml config:

linters:
  enable:
    - gocritic
linters-settings:
 gocritic:
    enabled-checks:
      - ruleguard
    settings:
      ruleguard:
        failOn: dsl,import
        rules: "${configDir}/gorules/myrule.go"

${configDir}/gorules/myrule.go:

// go:build ruleguard
package ruleguard

import "github.com/quasilyte/go-ruleguard/dsl"

func StringsSimplify(m dsl.Matcher) {
	// Some issues have simple fixes that can be expressed as
	// a replacement pattern. Rules can use Suggest() function
	// to add a quickfix action for such issues.
	m.Match(`strings.Replace($s, $old, $new, -1)`).
		Report(`this Replace call can be simplified`).
		Suggest(`strings.ReplaceAll($s, $old, $new)`)
}

Workaround

Execute the following command. This installs the required dependency in the go cache.
go get github.com/quasilyte/go-ruleguard/dsl

Additional Information

It turns out that two days prior to installing golangci-lint, I cleaned up the go cache by running go clean -modcache. This had the effect of removing github.com/quasilyte/go-ruleguard/dsl from the cache. The same problem would probably occur when doing a fresh installation of golangci-lint, because the ruleguard dependency would not be installed.

I'm not sure if this is a regression.

Proposed changes

Should gocritic automatically execute go get github.com/quasilyte/go-ruleguard/dsl? It does not seem right that the user has to manually install ruleguard. Also, the error is quite obscure, it's not obvious what needs to be done to workaround the problem.

[cristaloleg]

I think this is already solved with in a newer version. Can we resolve this? CC: @quasilyte