A new performance check: prefer operator comparisons to strings.Compare

[go101]

The current implementation of the strings.Compare function is not efficient, in a some deliberate way.
refs:

• strings: maybe strings.Compare should be optimized golang/go#50167
• cmd/vet: vet should recommend to use operators instead of strings.Compare to compare strings golang/go#50209

At least, for non-three-way comparisons, using operators to compare strings is always faster than using the strings.Compare function.

[peakle]

@go101
you can try to open pr to https://github.com/quasilyte/go-perfguard with optimization rule like:
m.Match(`strings.Compare($_, $_)`).Report(`strings.Compare in hot path`)

contribution guide: https://github.com/quasilyte/go-perfguard/blob/master/_docs/CONTRIBUTING.md

[quasilyte]

I would add them to go-critic though.
go-critic is something that is more useful for most users.
perfguard is an experiment that has ~0 integrations.

I think that checkers/rules is a good place for these.

[quasilyte]

By the way.

@go101 thank you for your books. ❤️

[peakle]

@quasilyte can be closed as i see

[quasilyte]

I think that we haven't implemented all of the suggested patterns.
Some of them can't be expressed in ruleguard rules beautifully, so maybe someone would like to create a separate checker for that.