Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add CONTRIBUTING.md #37

Closed
fexolm opened this issue May 9, 2018 · 7 comments · Fixed by #142
Closed

docs: add CONTRIBUTING.md #37

fexolm opened this issue May 9, 2018 · 7 comments · Fixed by #142
Labels
discussion Discussion and planning prior to implementation is needed release blocker

Comments

@fexolm
Copy link
Contributor

fexolm commented May 9, 2018 •
edited by quasilyte

We may need to add smth like contribution guideline which would formalize our workflow.
For example: we may add label "in progress" if someone currently working on task and remove it when switch on the other task.
It could save a lot of time if every team member would follow that rules.
@fexolm fexolm added the discussion Discussion and planning prior to implementation is needed label May 9, 2018
@quasilyte
Copy link
Member

Ok, makes sense.
We need CONTRIBUTING.md for sure.

@quasilyte quasilyte changed the title all: create contribution guideline CONTRIBUTING.md: create contribution guideline May 9, 2018
@quasilyte quasilyte changed the title CONTRIBUTING.md: create contribution guideline docs: add CONTRIBUTING.md May 9, 2018
@quasilyte
Copy link
Member

We also need to formalize how we tag issues and most commit messages.
It's not 100% precise and I have doubts sometimes (like in situation with this issue title),
but if we end up with exact rules, it'll be easier.

@quasilyte quasilyte mentioned this issue May 9, 2018
Merged
quasilyte pushed a commit that referenced this issue May 10, 2018
@fexolm
add CONTRIBUTING.org
8b88c94 
Updates #37
@fexolm
Copy link
Contributor Author

fexolm commented May 14, 2018

@quasilyte, closing?

@quasilyte
Copy link
Member

It lacks info about labels and workflow you bound to them.

@quasilyte
Copy link
Member

quasilyte commented May 14, 2018 •
edited

You can close this and open more specific issues, if you like it more this way.
But in it's current state, the document is not good enough.

@quasilyte
Copy link
Member

@tengufromsky, if you have any issues figuring out how to contribute to this project,
feel free to leave your questions here.

@quasilyte
Copy link
Member

Related: #116.

@fexolm fexolm mentioned this issue Jun 5, 2018
Merged
@fexolm fexolm closed this as completed Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion Discussion and planning prior to implementation is needed release blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs/contributing.md: add issues guide. go-critic/go-critic
2 participants
@quasilyte @fexolm