Use ReplaceAll

[breml]

Since Go version 1.12, strings.ReplaceAll and bytes.ReplaceAll are available. These should be preferred over their predecessors Replace (with n set to -1), because they make the code more readable.

Before:

x := strings.Replace(x, "foo", "bar", -1)
y := bytes.Replace(y, []byte("foo"), []byte("bar"), -1)

After:

x := strings.ReplaceAll(x, "foo", "bar")
y := bytes.ReplaceAll(y, []byte("foo"), []byte("bar"))

[cristaloleg]

Looks like a subcase of wrapperFunc checker

go-critic/checkers/testdata/wrapperFunc/positive_tests.go

Line 26 in a41a1de

/*! use strings.ReplaceAll method in `strings.Replace(s, "a", "b", -1)` */

[quasilyte]

wrapperFunc does that, but unfortunately, it suggests replace all forms even for Go 1.12-.
This is because we have no "target Go version" options right now.

[breml]

If I get this correctly, this is already included in go-critic, the only thing that could be improved is, the suggestion should only happen, if a version of Go >= 1.12 is used.
But to add version depended suggestions would need a major change, wouldn't it?

[quasilyte]

But to add version depended suggestions would need a major change, wouldn't it?

I think it's not that hard to add.
But it should be a separate issue probably. As for ReplaceAll, since most users have now go1.12+, the priority is lower than it was before.

[tehsphinx]

It would be really nice if the go version in go.mod would be used (if present).

[quasilyte]

We're using the model that most Go linters use right now: target Go version is specified using the -go parameter.
This parameter is also available (or will be available) via golangci-lint.