Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: add MacPorts install info #1038

Merged
merged 1 commit into from Apr 14, 2021
Merged

Conversation

herbygillot
Copy link
Contributor

No description provided.

@cristaloleg
Copy link
Member

Hm, why it's empty? 👀 https://ports.macports.org/?search=go-critic&search_by=name

We (as go-critic team) haven't created any MacPorts yet.

@herbygillot
Copy link
Contributor Author

Hm, why it's empty? 👀 https://ports.macports.org/?search=go-critic&search_by=name

To answer your question, the port for go-critic was just added several hours ago, so the MacPorts software catalog at macports.org has not synchronized yet. It should appear in an hour or two.

We (as go-critic team) haven't created any MacPorts yet.

I added a port for go-critic here: macports/macports-ports@8080641

Though it's not yet visible on the website, go-critic is already available to install via MacPorts:

$ port info go-critic
go-critic @0.5.5 (devel)

Description:          The most opinionated Go source code linter for code audit. Highly extensible Go source code linter
                      providing checks currently missing from other linters.
Homepage:             https://github.com/go-critic/go-critic

Build Dependencies:   go
Platforms:            darwin, freebsd, linux
License:              MIT
Maintainers:          Email: herby.gillot@gmail.com, GitHub: herbygillot
                      Policy: openmaintainer

@cristaloleg
Copy link
Member

cristaloleg commented Apr 14, 2021

Oh...that's great! Should we (as go-critic team) do something when we're pushing new (even minor) release? As I've understood it's not automated, am I right? 👀

UPD: I've checked PR's on MacPorts repo but haven't found something, you've push access to the master branch, that's why :D

@herbygillot
Copy link
Contributor Author

herbygillot commented Apr 14, 2021

Oh...that's great! Should we (as go-critic team) do something when we're pushing new (even minor) release? As I've understood it's not automated, am I right? 👀

That is correct, it's not automated. It's on me as maintainer to monitor for new releases and update the Portfile. Also anyone is welcome to open a pull request to update some software's Portfile, but you would need some idea of the Portfile format and also ideally be able to verify in a local MacPorts installation.

Hopefully we can get to a point of automating this someday.

@herbygillot
Copy link
Contributor Author

herbygillot commented Apr 14, 2021

Also go-critic has now appeared on macports.org: https://ports.macports.org/port/go-critic/summary

@cristaloleg cristaloleg changed the title README: add MacPorts install info readme: add MacPorts install info Apr 14, 2021
@cristaloleg cristaloleg merged commit e0bdd14 into go-critic:master Apr 14, 2021
@cristaloleg
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants