Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(newDeref): ignore generics #1273

Merged
merged 1 commit into from
Oct 6, 2022
Merged

fix(newDeref): ignore generics #1273

merged 1 commit into from
Oct 6, 2022

Conversation

tmzane
Copy link
Contributor

@tmzane tmzane commented Oct 5, 2022

fixes #1272

@tmzane
Copy link
Contributor Author

tmzane commented Oct 5, 2022

@quasilyte @cristaloleg would you take a look? thank you

@tmzane
Copy link
Contributor Author

tmzane commented Oct 5, 2022

Also I've noticed that the badRegexp test does not pass with go 1.19.1 🤔

make test-checker
--- FAIL: TestCheckers/badRegexp (0.05s)

Is it ok?

@quasilyte
Copy link
Member

Is it ok?

You can open a new issue about it. I haven't checked 1.19 yet.

@quasilyte quasilyte merged commit 6d910ba into go-critic:master Oct 6, 2022
@quasilyte
Copy link
Member

🎉

@tmzane tmzane deleted the newderef-ignore-generics branch October 6, 2022 12:27
@quasilyte quasilyte mentioned this pull request Oct 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quasilyte quasilyte quasilyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

newDeref: possible false-positive with generics
2 participants
@tmzane @quasilyte