Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(badRegexp): use stable sort #1275

Merged
merged 1 commit into from
Oct 7, 2022
Merged

fix(badRegexp): use stable sort #1275

merged 1 commit into from
Oct 7, 2022

Conversation

tmzane
Copy link
Contributor

@tmzane tmzane commented Oct 6, 2022

fixes #1274

@tmzane
Copy link
Contributor Author

tmzane commented Oct 6, 2022

According to Go's release policy the last two major versions are supported, does go-critic follow the same policy?

If so, go1.19 has been officially released, is it time to update the CI workflow to go: [1.18, 1.19]?

I'd be happy to help 😎

cristaloleg
cristaloleg approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@quasilyte quasilyte merged commit 90f4778 into go-critic:master Oct 7, 2022
@tmzane tmzane deleted the badregexp-use-stable-sort branch October 7, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristaloleg cristaloleg cristaloleg approved these changes

@quasilyte quasilyte quasilyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

badRegexp: tests fail with go1.19
3 participants
@tmzane @cristaloleg @quasilyte