Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new method for ruleguard warnings #1280

Merged
merged 3 commits into from
Oct 11, 2022

Conversation

peakle
Copy link
Contributor

@peakle peakle commented Oct 11, 2022

add new warn method without ast.Node usage: #1276

@peakle peakle force-pushed the usePosExceptNodeInWarnMethod branch from b4fc03c to b3a6ddc Compare October 11, 2022 10:16
@peakle peakle changed the title replace ast.Node by token.Pos for escape pointer leaking add new method for ruleguard warnings Oct 11, 2022
Copy link
Member

@quasilyte quasilyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@quasilyte quasilyte merged commit 93d30ad into go-critic:master Oct 11, 2022
@ldez ldez mentioned this pull request Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants