checker/rangeValCopy: stop panicking #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I asked in Gophers slack what would be the best way to handle this. |
|
Let's merge it for now. I'll probably file a Go proposal that would ask a new (safe) Sizeof function. |
quasilyte
approved these changes
Jul 27, 2023
|
@cristaloleg @quasilyte Thanks, guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1354
This PR should fix the problem. Fix is somewhat hacky but at least there will be no panics.
In short: having interface as a generic field isn't supported by
go/types(assert failure). Instead of copyinggo/typesfunctions and fixing it it's simpler to recover from a panic and ignore this struct in a checker.