Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: improve type parenthesis checker warning messages #201

Merged
merged 7 commits into from
Jun 12, 2018
Merged

lint: improve type parenthesis checker warning messages #201

merged 7 commits into from
Jun 12, 2018

Conversation

quasilyte
Copy link
Member

Fixes #5
Updates #200

cristaloleg
cristaloleg previously approved these changes Jun 12, 2018
View reviewed changes
cristaloleg
cristaloleg previously approved these changes Jun 12, 2018
View reviewed changes
fexolm
fexolm reviewed Jun 12, 2018
View reviewed changes
Copy link
Contributor

@fexolm fexolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do astcopy.go should be in commit?

@quasilyte
Copy link
Member Author

@fexolm, I'll move it to separate repo to then. :)
Will send updated PR later.

fexolm
fexolm reviewed Jun 12, 2018
View reviewed changes
Copy link
Contributor

@fexolm fexolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fix vendor

@quasilyte
Copy link
Member Author

I'm almost ready.
https://github.com/go-toolsmith/astcopy
Expect another update this evening.

@quasilyte
Copy link
Member Author

Don't look into astcopy.go code. It's full of pain and misery.

@quasilyte
Copy link
Member Author

Ok, go get github.com/go-toolsmith/astcopy and we're ready to roll.

cristaloleg
cristaloleg previously approved these changes Jun 12, 2018
View reviewed changes
@quasilyte quasilyte merged commit 3508daa into master Jun 12, 2018
@quasilyte quasilyte deleted the quasilyte/improve_parenthesis_warnings branch June 12, 2018 18:27
@quasilyte quasilyte mentioned this pull request Jun 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fexolm fexolm fexolm left review comments

@cristaloleg cristaloleg cristaloleg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@quasilyte @cristaloleg @fexolm