Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove panic from newQemuHelper #413

Open
obbardc opened this issue Jul 5, 2023 · 1 comment
Open

remove panic from newQemuHelper #413

obbardc opened this issue Jul 5, 2023 · 1 comment
Labels
fix-under-review

Comments

@obbardc
Copy link
Member

obbardc commented Jul 5, 2023

This is the last panic in the code and instead of panicking should be reworked to bubble up an error.
@obbardc obbardc added this to the v1.1.3 milestone Jul 5, 2023
obbardc added a commit to obbardc/debos that referenced this issue Jul 17, 2023
@obbardc
commands: Rework newQemuHelper to bubble-up error instead of panicing
b8043e4 
Rather than panicing on error, bubble up an error so that the execution
may recover correctly and the error shown to the user.

Fixes: go-debos#413
Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
sjoerdsimons pushed a commit to obbardc/debos that referenced this issue Jul 24, 2023
@obbardc @sjoerdsimons
commands: Rework newQemuHelper to bubble-up error instead of panicing
6b236b3 
Rather than panicing on error, bubble up an error so that the execution
may recover correctly and the error shown to the user.

Fixes: go-debos#413
Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
obbardc added a commit to obbardc/debos that referenced this issue Jul 26, 2023
@obbardc
commands: Rework newQemuHelper to bubble-up error instead of panicing
20281cc 
Rather than panicing on error, bubble up an error so that the execution
may recover correctly and the error shown to the user.

Fixes: go-debos#413
Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
@obbardc obbardc self-assigned this Jul 27, 2023
@obbardc
Copy link
Member Author

obbardc commented Aug 9, 2023

Will be fixed under #303

@obbardc obbardc closed this as completed Aug 9, 2023
@obbardc obbardc reopened this Aug 9, 2023
@obbardc obbardc removed their assignment Aug 9, 2023
@obbardc obbardc removed this from the v1.1.3 milestone Jan 10, 2024
obbardc added a commit to obbardc/debos that referenced this issue Jan 10, 2024
@obbardc
commands: Rework newQemuHelper to bubble-up error instead of panicing
0f9b045 
Rather than panicing on error, bubble up an error so that the execution
may recover correctly and the error shown to the user.

Fixes: go-debos#413
Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix-under-review
Projects
Debos development
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@obbardc