Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The MBR extended implementation causes a problem with a non-MBR configuration #473

Closed
robertkirkman opened this issue Jan 18, 2024 · 2 comments · Fixed by #475
Closed

The MBR extended implementation causes a problem with a non-MBR configuration #473

robertkirkman opened this issue Jan 18, 2024 · 2 comments · Fixed by #475

Comments

@robertkirkman
Copy link

Hi I don't know enough about the project yet to know how to create a minimal reproducible example, but when i use this file with debos, if I use commit 03ec3cb of debos it works but if I use commit da773cc or any of the recent commits after that, the debos command gets stuck inside the fakemachine because of a partition named "extended" getting incorrectly created in the wrong place even though the .yaml file specifies gpt and not mbr

If I have time I will try to create a minimal reproducible example
@robertkirkman robertkirkman mentioned this issue Jan 18, 2024
Merged
sjoerdsimons added a commit to sjoerdsimons/debos that referenced this issue Jan 20, 2024
@sjoerdsimons
partitioning: Avoid msdos special cases for other types
a1aa670 
The extended partition handling for msdos accidentally got applied to
all partition types. Ensure and be more defensive against msdos special
handling getting applied to other partition types

Fixes: go-debos#473
sjoerdsimons added a commit to sjoerdsimons/debos that referenced this issue Jan 20, 2024
@sjoerdsimons
partitioning: Avoid msdos special cases for other types
7870756 
The extended partition handling for msdos accidentally got applied to
all partition types. Ensure and be more defensive against msdos special
handling getting applied to other partition types

Fixes: go-debos#473
@robertkirkman
Copy link
Author

Thank you I tested that patch and the same .yaml file I tested with the other 2 versions of debos works with your msdos-fixes branch!

@sjoerdsimons sjoerdsimons linked a pull request Jan 20, 2024 that will close this issue
Fix accidental application of msdos quirks to gpt #475
Merged
@sjoerdsimons
Copy link
Member

Thanks for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix accidental application of msdos quirks to gpt sjoerdsimons/debos
2 participants
@sjoerdsimons @robertkirkman