actions: apt: Fix apt output not shown in gitlab CI #281
+29
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we print to the log to stdout whatever the downstream command prints to stdout|stderr and let the shell on the host deal with the handling of any special characters. In the case of some non-interactive shells (like GitLab CI) any lines printed to its stdout with special characters (like \b or \r) are simply not printed to the web interface. Some commands used by actions (apt, mkfs...) use these special characters to print progress to the user, which is useful in interactive environments but can completely break non-interactive usage like in Debos. Let's fix these environments by removing the offending characters before printing the output to the shell. Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
Showing the update progress can mess up non-interactive shells where moving the cursor is unsupported. For instance, GitLab CI just doesn't print any line which attempts to move the cursor, which means the output for the apt commands is not shown. Disable the apt progress from being shown, only showing the apt output log. Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
evelikov
reviewed
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.