ci: Add linter stage to workflow #423
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obbardc
force-pushed
the
wip/obbardc/go-lint
branch
2 times, most recently
from
a0876f4
to
b723062
Compare
obbardc
force-pushed
the
wip/obbardc/go-lint
branch
from
b723062
to
230f42a
Compare
Ensure that submitted merge requests are run through a linter check to keep high code quality. Run the linter job in parallel with the unit test jobs but do not run subsequent Docker container tests (which are heavy on resources) if the linter job fails. Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
obbardc
force-pushed
the
wip/obbardc/go-lint
branch
from
230f42a
to
f0234e8
Compare
|
I've played around with this a while ago (see #378) but didn't manage to get past the lint issues in ostree. How did you manage to handle those? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that submitted merge requests are run through a linter check to keep high code quality.
NOTE: Need to fix linter/fmt errors before undrafting PR.