actions: run: Set postprocess working directory to artifact directory #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding the reproducer (or variant thereof) as a test case would be great. |
obbardc
force-pushed
the
wip/obbardc/artifactdir-postprocess
branch
from
be044e5
to
c71008f
Compare
Currently Command.Dir is unsed; hook it up such that when commands are not running in a chroot, the working directory can be set. Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
Currently any run action tagged as postprocess will be ran in the recipe directory. The artifacts are stored in this directory by default, unless --artifactdir is passed to Debos to change where the artifacts are stored. The run action documentation states: postprocess -- if set script or command is executed after all other commands and has access to the recipe directory ($RECIPEDIR) and the artifact directory ($ARTIFACTDIR). The working directory will be set to the artifact directory. But this is wrong; currently the working directory of postprocess commands is set to the recipe directory. Set the working directory to the artifact directory instead to allow postprocess commands to be ran in the correct location. Fixes: #345 Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
obbardc
force-pushed
the
wip/obbardc/artifactdir-postprocess
branch
from
c71008f
to
c43257e
Compare
| @@ -254,6 +254,11 @@ func (cmd Command) Run(label string, cmdline ...string) error { | |||
| exe.Env = append(os.Environ(), cmd.extraEnv...) | |||
| } | |||
|
|
|||
| // Allow working directory to be set for commands not running in chroot | |||
| if len(cmd.Dir) > 0 && cmd.ChrootMethod == CHROOT_METHOD_NONE { | |||
There was a problem hiding this comment.
why only for CHROOT_METHOD_NONE
sjoerdsimons
requested changes
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently any run action tagged as postprocess will be ran in the recipe
directory. The artifacts are stored in this directory by default, unless
--artifactdir is passed to Debos to change where the artifacts are stored.
The run action documentation states:
postprocess -- if set script or command is executed after all other
commands and has access to the recipe directory ($RECIPEDIR) and the
artifact directory ($ARTIFACTDIR). The working directory will be set to
the artifact directory.
But this is wrong; currently the working directory of postprocess commands
is set to the recipe directory. Set the working directory to the artifact
directory instead to allow postprocess commands to be ran in the correct
location.
Fixes: #345