Time string not always displayed

[sylr]

1. What version of Delve are you using (dlv version)?

dlv version
Delve Debugger
Version: 1.20.2
Build: $Id: e0c278ad8e0126a312b553b8e171e81bcbd37f60 $

3. What version of Go are you using? (go version)?

go version go1.20.3 darwin/arm64

5. What operating system and processor architecture are you using?
   Darwin
6. What did you do?

package main

import (
	"fmt"
	"time"
)

type Interval struct {
	Start time.Time
	End   time.Time
}

func main() {
	t := time.Now().Truncate(time.Second)
	i := Interval{Start: t, End: t.Add(time.Hour * 24)}

	ts := make([]Interval, 0, 1)
	ts = append(ts, i)

	fmt.Printf("ts: %v\n", ts)
}

9. What did you expect to see?

I'd like to see the Time string in ts[0].Start and ts[0].End.

11. What did you see instead?

[alexsaezm]

For what it's worth, this also happens on linux/amd64. I'm wondering what should be the expected output, exactly like i.Start?

[sylr]

For what it's worth, this also happens on linux/amd64. I'm wondering what should be the expected output, exactly like i.Start?

That would be my expectation yes.

[sylr]

Also, is that normal that ts[0].Start and ts[0].End are displayed as *time.Time instead of time.Time ?

[aarzilli]

I think because of the nesting depth those time.Time value don't get loaded immediately and therefore don't get the formatting.

[alexsaezm]

For the record, looks like dap can be configured so it might interested to add a configuration option like "depth" and a sane default.

If the solution sounds ok, I'll work on a PR.

[derekparker]

I'm not sure if the DAP folks actually intend for it to be configurable given https://github.com/go-delve/delve/blob/master/service/dap/server.go#L256. We could experiment with increasing the depth to 2, or maybe this is something better solved on the VSCode side?

cc @hyangah

[suzmue]

Looks like this is actually just a bug in server/dap, the variable is loaded correctly but the variable with the loaded information isn't used to format the output. Will send a PR to fix.

[suzmue]

Sent a PR for fixing the bug where the time.Time arguments have the values.

We also need to address the inconsistency with Interval sometimes having the children loaded and displaying the formatted string in its value and sometimes not. (i displays time.Time but ts[0] doesn't).

I think ideally we will be able to avoid making the depth configurable, so maybe trying to make the depth 2 could be a good way to resolve it. We may be able to be selective about where we increase the depth as well.