service/dap: validate the client configurations in initialize request #2435
Conversation
The client can specify certain configurations in the initialize request. For example, pathFormat determines the pathFormat. We do not currently support configuring pathFormat, linesStartAt1, or columnsStartAt1, so we report an error if the client attempts to set these to an unsupported value.
There was a problem hiding this comment.
I have conflicting thoughts about this. What prompted this change? Unfortunately, the DAP spec doesn't make it clear if we should be responding with an error or just ignoring the arguments we do not support: https://microsoft.github.io/debug-adapter-protocol/specification. The editor itself, for example, just ignores quietly some of the things that the adapter supports, but the editor does not. I do see a mention here https://microsoft.github.io/debug-adapter-protocol/overview that "A debug adapter is expected to return error messages that honor this locale."
This change was prompted by one of our tests in the vscode-go extension, which tests that we expect an error response when provided with an invalid 'pathFormat'. The vscode-debugadapter checks that pathFormat = 'path' and returns an errror if it is something else. I think this is a bit different from just ignoring something that we do not support, because if someone sets "pathFormat" to "url", they are saying that they plan to send urls instead of filepaths. Or if they set LinesStartAt1=false, then every line number they send to us and we send to them will be off by 1. This would result in a very broken experience for the user, that may not be obvious at first (for example when it comes to line numbers). |
|
Just rebased this change. @aarzilli @derekparker I don't think there is anything left to do on this could you please review? Thanks! |
…go-delve#2435) The client can specify certain configurations in the initialize request. For example, pathFormat determines the pathFormat. We do not currently support configuring pathFormat, linesStartAt1, or columnsStartAt1, so we report an error if the client attempts to set these to an unsupported value.
* service/dap: support pause request * service/dap: validate the client configurations in initialize request (#2435) The client can specify certain configurations in the initialize request. For example, pathFormat determines the pathFormat. We do not currently support configuring pathFormat, linesStartAt1, or columnsStartAt1, so we report an error if the client attempts to set these to an unsupported value. * TeamCity: fix Windows builds (#2467) Bintray is shutting down and the URL we used to install mingw is no longer available. Use chocolatey instead. * proc/native: low level support for watchpoints in linux/amd64 (#2301) Adds the low-level support for watchpoints (aka data breakpoints) to the native linux/amd64 backend. Does not add user interface or functioning support for watchpoints on stack variables. Updates #279 * simplify pause test Co-authored-by: Polina Sokolova <polinasok@users.noreply.github.com> Co-authored-by: Suzy Mueller <suzmue@golang.org> Co-authored-by: Alessandro Arzilli <alessandro.arzilli@gmail.com>
…go-delve#2435) The client can specify certain configurations in the initialize request. For example, pathFormat determines the pathFormat. We do not currently support configuring pathFormat, linesStartAt1, or columnsStartAt1, so we report an error if the client attempts to set these to an unsupported value.
The client can specify certain configurations in the initialize request.
For example, pathFormat determines the pathFormat. We do not currently
support configuring pathFormat, linesStartAt1, or columnsStartAt1, so
we report an error if the client attempts to set these to an
unsupported value.