Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proc: Simplify eBPF backend implementation #3325

Merged
merged 1 commit into from Apr 24, 2023

Conversation

chenhengqi
Copy link
Contributor

  • Remove standard C headers since we have vmlinux.h already
  • Simplify get_goroutine_id() implementation, this reduces a map and thus reduces runtime memory comsumption.

While at it, unify all indention using 4 spaces.

* Remove standard C headers since we have vmlinux.h already
* Simplify get_goroutine_id() implementation, this reduces a map
  and thus reduces runtime memory comsumption.

While at it, unify all indention using 4 spaces.

Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>
@alexandear
Copy link
Contributor

For the Go code, we have gofmt. Maybe we should use a formatting tool for the C code? E.g. ClangFormat:

clang-format is located in clang/tools/clang-format and can be used to format C/C++/Java/JavaScript/JSON/Objective-C/Protobuf/C# code.

We can check the formatting of the C-code on TeamCity by adding a clang-format step.

Copy link
Member

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the patch! In the future however please put formatting changes in a separate PR or at least a separate commit to make it easier to view actual changes from formatting changes.

@derekparker derekparker merged commit 64d5ce2 into go-delve:master Apr 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants