Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/dlv,service/dap: use randomized name as default output binary #3366

Merged
merged 1 commit into from May 16, 2023

Conversation

aarzilli
Copy link
Member

Using a fixed path as the default output binary means that executing
Delve twice in the same directory will cause the second invocation to
overwrite the output binary of the first instance of Delve, making the
restart command not work correctly.

Fixes #3345

Using a fixed path as the default output binary means that executing
Delve twice in the same directory will cause the second invocation to
overwrite the output binary of the first instance of Delve, making the
restart command not work correctly.

Fixes go-delve#3345
Copy link
Member

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekparker derekparker merged commit 84b757a into go-delve:master May 16, 2023
1 of 2 checks passed
@valscale
Copy link

Thank you so much!!!

@Kevin40481 Kevin40481 linked an issue May 18, 2023 that may be closed by this pull request
@matwachich
Copy link

The problem with the randomized exe name is that if I debug an application that uses networking (aka listening to some port), it will triggers windows firewall autorisation dialog for each and every debug session!

The fixe should be to use an incremental exe name:

  • __debug_bin.exe by default (old behaviour)
  • if __debug_bin.exe exists, then use __debug_bin_1.exe, then __debug_bin_2.exe ... and so on

This will solve the overwrite problem, and not cause the firewall problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants