Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/proc,pkg/terminal: close response body in tests #3372

Merged
merged 1 commit into from May 17, 2023

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented May 17, 2023

Go Response Body MUST be closed, even if you don’t read it

https://manishrjain.com/must-close-golang-http-response

@aarzilli aarzilli merged commit c5d9baa into go-delve:master May 17, 2023
1 of 2 checks passed
@alexandear alexandear deleted the close-resp-body branch May 17, 2023 10:56
@Kevin40481 Kevin40481 linked an issue May 18, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kingbug
2 participants