Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proc: move StepInstruction method to TargetGroup #3488

Merged
merged 1 commit into from Sep 20, 2023

Conversation

aarzilli
Copy link
Member

Move StepInstruction method to TargetGroup since it will need access to
the process group on Windows to call WaitForDebugEvent.

Copy link
Member

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@derekparker
Copy link
Member

Needs rebase.

Move StepInstruction method to TargetGroup since it will need access to
the process group on Windows to call WaitForDebugEvent.
@aarzilli aarzilli merged commit db7e60a into go-delve:master Sep 20, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants