Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/dap: support waitfor option for 'dap attach' only #3656

Merged
merged 1 commit into from Feb 7, 2024

Conversation

aarzilli
Copy link
Member

@aarzilli aarzilli commented Feb 6, 2024

Add a waitfor option for 'dap attach' that waits for a process with a
given name to appear before attaching to it.

This recovers PR #3584, originally by @muggle-nil, which was fine
except for a broken test.

Add a waitfor option for 'dap attach' that waits for a process with a
given name to appear before attaching to it.

This recovers PR go-delve#3584, originally by @muggle-nil, which was fine
except for a broken test.
Copy link
Member

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekparker derekparker merged commit f2b3b18 into go-delve:master Feb 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants