-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NM Various Enhancements #285
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eCharts supports Chart's `dataset` as an array and indexing it in a Series with `datasetIndex`. This replaces the `Dataset` Chart config field with the function `AddDataset`. It also adds `WithDatasetIndex` as an option for `SeriesOpts` The `DatasetList` is JSON rendered as a single object, as before. But multiple Datasets are rendered as Array. This is a breaking change: ``` // old chart.Dataset = opts.Dataset{Source: test} // new chart.AddDataset(opts.Dataset{Source: test}) ```
Also some whitespace changes per go fmt for doc comments * Tooltip.ValueFormatter * AxisPointer.Show * AxisPointer.Label * AxisLabel.BackgroundColor * XAxis.AxisPointer * YAxis.AxisPointer * DataZoom.LabelFormatter
Koooooo-7
reviewed
May 10, 2023
Koooooo-7
reviewed
May 10, 2023
Koooooo-7
reviewed
May 10, 2023
Koooooo-7
added
attention
Attention may include breaking changes
enhancement
New feature or request
awesome
labels
May 10, 2023
This was referenced May 11, 2023
renamed `funcPat` to `newlineTabPat` for clarity
Koooooo-7
approved these changes
May 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've been loving this library -- such a great integration of Golang <> JSON <> eCharts. It took me a while to isolate my changes, but I finally rebased them for a PR. Since one has a breaking change, maybe you want to separate it and I will if you ask me to.
Three changes, one adds some missing fields:
Another strips
//
comments from JavaScript code, while still havingFuncNoStripOpts
if somehow that's not wanted. But most JavaScript code will. This makes usinggo:embed
much easier (which I'll add a PR toexamples
about).The last adds support for multiple datasets. This is great for issues like It has #169 with multiple charts. This has one breaking change, but in my opinion it adds so much power and harmonizes the syntax:
Type of change
Examples:
A multi-dataset example would be super useful. I don't have much time but hope to get to it.
I also want to make an example using
go:embed
since it is so powerful (also needsgo 1.16
whereas examples only usesgo 1.15
). But I won't have time for a while too. Here's the idea:js/tooltip.js