Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix LanguagesByFilename case & improve logging #170

Merged
merged 5 commits into from
Sep 13, 2023
Merged

Conversation

bzz
Copy link
Member

@bzz bzz commented Sep 6, 2023

  1. Fixes a first test failure from Update Linguist to v7.26.0 #167 (I added a wrong fixture in Small improvements #168)
  2. refactoring to a single implementation of maybeCloneLinguist() shared between all 3 tests suits that rely on it
  3. force Python CI profile to use legacy build system

@bzz bzz changed the title test: actually a correct LanguagesByFilename case test: fix LanguagesByFilename case & improve logging Sep 6, 2023
@bzz bzz added the enhancement New feature or request label Sep 6, 2023
@bzz
Copy link
Member Author

bzz commented Sep 6, 2023

Annoying as it is, Python CI profiles started to fail with

      /tmp/tmpqwqr2e71.build-temp/_c_enry.c:569:10: fatal error: /home/runner/work/go-enry/go-enry/.shared/libenry.h: No such file or directory

despite having the dependencies fixed and without any changes on our side 😞 (and the logs of the old runs expired so it is hard to debug). Locally Python bindings can be built and tests run (sans bumping pytest version for Python 3.10).

I guess we should just ignore it for now, and fix later when time permits 🤷

@bzz bzz mentioned this pull request Sep 9, 2023
@bzz
Copy link
Member Author

bzz commented Sep 9, 2023

After

pip install -r python/requirements.txt
pip install -r python/requirements.dev.txt

a pip -v install -e python produces VERY different output for the same pip 23.2.1 locally and on CI 🤔 .

If no one figures it out before that, I'm planning to take another look next week, and if that doesn't help - create a separate issue for fixing CI Python profiles and merge this as-is.

@bzz
Copy link
Member Author

bzz commented Sep 13, 2023

Merging as Python CI is 🟢 😎

@bzz bzz merged commit c3899f1 into master Sep 13, 2023
28 checks passed
@bzz bzz deleted the tiny-fixes-2 branch September 13, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

1 participant