Improve env shebang parsing to detect correct interpreter #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafriks
force-pushed
the
feat/improve_shebang
branch
from
82513f2
to
4686615
Compare
lafriks
changed the title
lafriks
commented
Sep 25, 2021
| @@ -111,13 +111,6 @@ func getFirstLanguageAndSafe(languages []string) (language string, safe bool) { | |||
| return | |||
| } | |||
|
|
|||
| // getLanguageBySpecificClassifier returns the most probably language for the given content using | |||
| // classifier to detect language. | |||
| func getLanguageBySpecificClassifier(content []byte, candidates []string, classifier classifier) (language string, safe bool) { | |||
There was a problem hiding this comment.
this function is not used anywhere in the code
bzz
approved these changes
Sep 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Linguist commit github-linguist/linguist@de19dc1
Also remove unused function and adds additional test cases from Linguist