Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bench): use Writer in OTEL encode #11

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Conversation

ernado
Copy link
Member

@ernado ernado commented Jan 12, 2022

name           old time/op    new time/op    delta
OTEL_Write-32     389ns ± 3%     236ns ± 2%  -39.24%  (p=0.000 n=10+10)

name           old speed      new speed      delta
OTEL_Write-32  1.09GB/s ± 3%  1.79GB/s ± 2%  +64.56%  (p=0.000 n=10+10)

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #11 (4897c44) into main (0a14eba) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   99.53%   99.63%   +0.10%     
==========================================
  Files          29       29              
  Lines        1919     1921       +2     
==========================================
+ Hits         1910     1914       +4     
+ Misses          9        7       -2     
Impacted Files Coverage Δ
w.go 95.55% <100.00%> (+4.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a14eba...4897c44. Read the comment docs.

@ernado ernado merged commit 61a3eee into main Jan 12, 2022
@tdakkota tdakkota deleted the test/otel-use-writer branch January 19, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant