Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: inline reading to consume #17

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

tdakkota
Copy link
Member

name                        old time/op    new time/op    delta
Valid/canada.json-12          3.96ms ± 3%    3.88ms ± 1%   -1.99%  (p=0.017 n=10+9)
Valid/citm_catalog.json-12    1.99ms ± 2%    1.85ms ± 2%   -6.94%  (p=0.000 n=10+10)
Valid/floats.json-12          2.89µs ± 1%    2.84µs ± 1%   -1.54%  (p=0.000 n=10+9)
Valid/large.json-12           55.2µs ± 2%    49.6µs ± 3%  -10.10%  (p=0.000 n=10+10)
Valid/medium.json-12          3.72µs ± 1%    3.73µs ± 2%     ~     (p=0.838 n=10+10)
Valid/otel_ex_1.json-12        719ns ± 5%     619ns ± 1%  -13.91%  (p=0.000 n=10+10)
Valid/small.json-12            396ns ± 2%     346ns ± 3%  -12.48%  (p=0.000 n=10+10)
Valid/twitter.json-12         1.08ms ± 3%    1.06ms ± 2%   -1.75%  (p=0.017 n=10+9)

name                        old speed      new speed      delta
Valid/canada.json-12         569MB/s ± 3%   581MB/s ± 1%   +2.00%  (p=0.017 n=10+9)
Valid/citm_catalog.json-12   892MB/s ± 2%   959MB/s ± 2%   +7.46%  (p=0.000 n=10+10)
Valid/floats.json-12         807MB/s ± 1%   819MB/s ± 1%   +1.56%  (p=0.000 n=10+9)
Valid/large.json-12          509MB/s ± 2%   567MB/s ± 2%  +11.25%  (p=0.000 n=10+10)
Valid/medium.json-12         703MB/s ± 1%   702MB/s ± 2%     ~     (p=0.853 n=10+10)
Valid/otel_ex_1.json-12      722MB/s ± 6%   837MB/s ± 1%  +16.03%  (p=0.000 n=10+10)
Valid/small.json-12          508MB/s ± 2%   581MB/s ± 4%  +14.27%  (p=0.000 n=10+10)
Valid/twitter.json-12        597MB/s ± 3%   608MB/s ± 2%   +1.77%  (p=0.017 n=10+9)

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #17 (1f8d31d) into main (0762622) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files          29       29           
  Lines        2011     2017    +6     
=======================================
+ Hits         2004     2010    +6     
  Misses          6        6           
  Partials        1        1           
Impacted Files Coverage Δ
dec.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0762622...1f8d31d. Read the comment docs.

Copy link
Member

@ernado ernado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fuzzing ok

@ernado ernado marked this pull request as ready for review January 13, 2022 19:54
@ernado ernado merged commit ec24791 into go-faster:main Jan 13, 2022
@tdakkota tdakkota deleted the feat/help-inline-consume branch January 14, 2022 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants