Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unroll skipStr loop #22

Merged
merged 4 commits into from
Jan 16, 2022
Merged

Conversation

tdakkota
Copy link
Member

Valid/bools.json-4           2.19µs ± 0%    2.21µs ± 2%   +1.03%  (p=0.005 n=12+15)
Valid/canada.json-4          4.96ms ± 1%    4.99ms ± 2%     ~     (p=0.093 n=12+15)
Valid/citm_catalog.json-4    2.63ms ± 2%    2.40ms ± 1%   -8.71%  (p=0.000 n=15+14)
Valid/floats.json-4          3.86µs ± 1%    3.84µs ± 2%   -0.58%  (p=0.032 n=14+13)
Valid/large.json-4           62.8µs ± 3%    47.6µs ± 1%  -24.21%  (p=0.000 n=14+14)
Valid/medium.json-4          4.68µs ± 1%    3.73µs ± 2%  -20.23%  (p=0.000 n=15+13)
Valid/nulls.json-4           2.02µs ± 2%    2.02µs ± 2%     ~     (p=0.289 n=14+14)
Valid/otel_ex_1.json-4        925ns ± 2%     662ns ± 3%  -28.46%  (p=0.000 n=14+14)
Valid/small.json-4            452ns ± 3%     394ns ± 2%  -12.85%  (p=0.000 n=15+15)
Valid/tiny.json-4            61.5ns ± 2%    65.7ns ± 3%   +6.82%  (p=0.000 n=14+14)
Valid/twitter.json-4         1.15ms ± 3%    0.83ms ± 0%  -27.60%  (p=0.000 n=14+12)

@tdakkota tdakkota marked this pull request as draft January 16, 2022 07:35
@codecov
Copy link

codecov bot commented Jan 16, 2022

Codecov Report

Merging #22 (c048666) into main (0493760) will decrease coverage by 0.07%.
The diff coverage is 97.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   99.19%   99.11%   -0.08%     
==========================================
  Files          29       29              
  Lines        2106     2158      +52     
==========================================
+ Hits         2089     2139      +50     
- Misses         13       15       +2     
  Partials        4        4              
Impacted Files Coverage Δ
w_str.go 100.00% <ø> (ø)
dec_skip.go 98.37% <97.46%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0493760...c048666. Read the comment docs.

@ernado ernado marked this pull request as ready for review January 16, 2022 09:11
@ernado ernado merged commit dcb5603 into go-faster:main Jan 16, 2022
@tdakkota tdakkota deleted the feat/faster-str-decode branch January 16, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants