-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add packaging using new implementation #20
Add packaging using new implementation #20
Conversation
I've quickly looked at the implementation and the code looks very good to me. |
Nice work! I've left some comments. |
@GeertJohan can we get one last review before this gets merged? edit: misclick the closed&comment button 🥇 |
edit: Its in the .gitignore, I missed that. |
Yes, but don't really like it |
Awesome job @jld3103, I just packaged one of my applications as a deb, very cool. I feel there are a few last points that need to be addressed before we can release this into the wild.
A nice-to have, but not required to merge this PR: |
@GeertJohan Done. |
Thanks a lot @jld3103 ! |
Using the new implementation from here
Previously was #15