-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Openapi3.1 #64
base: main
Are you sure you want to change the base?
Openapi3.1 #64
Conversation
ee38b7b
to
dd7253d
Compare
Example string `json:"example,omitempty" yaml:"example"` | ||
} | ||
|
||
type MimeType string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about using textproto.MIMEHeader?
It may allow for more flexible matching on content types parameters (Ref: https://www.rfc-editor.org/rfc/rfc9110#name-parameters and https://www.rfc-editor.org/rfc/rfc9110#name-content-negotiation-fields )
More of a long-term hypothetical question, I wouldn't expect content negotiation to be tackled in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not in the future, that could be interesting
|
||
// Adds a description to the route. Keeps the autogenerated description. | ||
func (r Route[ResponseBody, RequestBody]) OverrideDescription(description string) Route[ResponseBody, RequestBody] { | ||
r.operation.Description += description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if i get the naming wrong, override indicates not concatenating to me.
r.operation.Description = description
No description provided.