-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
submodule.path & submodule.branch is empty #373
Comments
I'm seeing something related, where the repo's submodule status is different after code has examined it, than before. Steps to reproduce:
|
For reasons not yet clear to me, using Credit to @another-rex for identifying this. |
@another-rex identified this solution to go-git/go-git#373
So while using |
@andrewpollock We could improve the documentation to highlight the behaviour. Would you be keen on proposing a PR to that effect? |
@pjbgf Unfortunately I don't feel like I (yet) have enough of a handle on what's actually going on under the hood to be able to do that. |
Latest debugging for the unexpected side-effects, I have a narrower reproduction case in https://gist.github.com/andrewpollock/0c51ca92fdb77f1b0671a69c8187d949
So the misbehaviour is somewhere within Line 102 in 6252084
|
To help us keep things tidy and focus on the active tasks, we've introduced a stale bot to spot issues/PRs that haven't had any activity in a while. This particular issue hasn't had any updates or activity in the past 90 days, so it's been labeled as 'stale'. If it remains inactive for the next 30 days, it'll be automatically closed. We understand everyone's busy, but if this issue is still important to you, please feel free to add a comment or make an update to keep it active. Thanks for your understanding and cooperation! |
I've added two submodules:
.gitmodules file:
go test code snippet:
output of the above code is
Please clarify if it's expected.
The text was updated successfully, but these errors were encountered: