Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SHA-1 **and** SHA-256 at the same time #899

Open
6543 opened this issue Oct 31, 2023 · 2 comments
Open

Support SHA-1 **and** SHA-256 at the same time #899

6543 opened this issue Oct 31, 2023 · 2 comments
Labels
help wanted Extra attention is needed
Milestone
v6.0.0

Comments

@6543
Copy link

6543 commented Oct 31, 2023 •
edited

the current implementation makes it hard to have go-git working if you need to support both scenarios.

see go-gitea/gitea#23894
related to #706
@6543 6543 mentioned this issue Oct 31, 2023
Merged
@AdamMajer
Copy link

It's related to this timeline -- #706

@pjbgf pjbgf added this to the v6.0.0 milestone Oct 31, 2023
@pjbgf
Copy link
Member

pjbgf commented Oct 31, 2023

Apart from the implementation side of things, one of the main issues for supporting this is breaking backwards compatibility with the current API. So I am marking this to the v6 release.

However, I am not entirely sure when exactly that would land. PRs for the SHA256 support are more than welcome.

@pjbgf pjbgf added the help wanted Extra attention is needed label Oct 31, 2023
This was referenced Nov 7, 2023
Open
Open
6543 added a commit to go-gitea/gitea that referenced this issue Jan 19, 2024
@AdamMajer @lunny @6543
Add support for sha256 repositories (#23894)
d68a613 
Currently only SHA1 repositories are supported by Gitea. This adds
support for alternate SHA256 with the additional aim of easier support
for additional hash types in the future.

Fixes: #13794
Limited by: go-git/go-git#899
Depend on: #28138

<img width="776" alt="图片" src="https://github.com/go-gitea/gitea/assets/81045/5448c9a7-608e-4341-a149-5dd0069c9447">

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: 6543 <6543@obermui.de>
AdamMajer added a commit to AdamMajer/gitea that referenced this issue Jan 22, 2024
@AdamMajer @lunny @6543
Add support for sha256 repositories (go-gitea#23894)
2a95162 
Currently only SHA1 repositories are supported by Gitea. This adds
support for alternate SHA256 with the additional aim of easier support
for additional hash types in the future.

Fixes: go-gitea#13794
Limited by: go-git/go-git#899
Depend on: go-gitea#28138

<img width="776" alt="图片" src="https://github.com/go-gitea/gitea/assets/81045/5448c9a7-608e-4341-a149-5dd0069c9447">

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: 6543 <6543@obermui.de>
henrygoodman pushed a commit to henrygoodman/gitea that referenced this issue Jan 31, 2024
@AdamMajer @lunny
@6543 @henrygoodman
Add support for sha256 repositories (go-gitea#23894)
c0f2739 
Currently only SHA1 repositories are supported by Gitea. This adds
support for alternate SHA256 with the additional aim of easier support
for additional hash types in the future.

Fixes: go-gitea#13794
Limited by: go-git/go-git#899
Depend on: go-gitea#28138

<img width="776" alt="图片" src="https://github.com/go-gitea/gitea/assets/81045/5448c9a7-608e-4341-a149-5dd0069c9447">

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: 6543 <6543@obermui.de>
silverwind pushed a commit to silverwind/gitea that referenced this issue Feb 20, 2024
@AdamMajer @lunny
@6543 @silverwind
Add support for sha256 repositories (go-gitea#23894)
6a9b559 
Currently only SHA1 repositories are supported by Gitea. This adds
support for alternate SHA256 with the additional aim of easier support
for additional hash types in the future.

Fixes: go-gitea#13794
Limited by: go-git/go-git#899
Depend on: go-gitea#28138

<img width="776" alt="图片" src="https://github.com/go-gitea/gitea/assets/81045/5448c9a7-608e-4341-a149-5dd0069c9447">

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: 6543 <6543@obermui.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
v6.0.0
Development

No branches or pull requests
3 participants
@AdamMajer @pjbgf @6543