-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor transport and drop git binary dependency #1111
Open
aymanbagabas
wants to merge
28
commits into
go-git:v6-exp
Choose a base branch
from
aymanbagabas:transport-refactor-transport
base: v6-exp
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor transport and drop git binary dependency #1111
aymanbagabas
wants to merge
28
commits into
go-git:v6-exp
from
aymanbagabas:transport-refactor-transport
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f036e92
to
fce6fea
Compare
pjbgf
reviewed
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the transport sub-package and implements server-side git operations like
UploadPack
andReceivePack
along with delegating client-side operations toSendPack
andFetchPack
following the canonical git implementation.file
,git
,ssh
andhttp
usingNeogotiatePack
,FetchPack
, andSendPack
.no-progress
,sideband
, andsideband64k
capabilities.packfile.Encoder
(needed to get thefile
transport to work with the pure server implementation)Future follow-ups:
git-daemon
support)git-http-backend
support)Needs: #1082
New transport api: https://gist.github.com/aymanbagabas/1b5ccc265ee62dd574c62d378b4b57bb
Supersedes: #757
Supersedes: #938
Fixes: #883
Fixes: #838