fix(submodule): cloning submodule using ssh url

[Hunter-Thompson]

Changed from net/url stdlib to git-urls

According to the function description it does the following things:

Parse parses rawurl into a URL structure. Parse first attempts to find a standard URL with a valid Git transport as its scheme. If that cannot be found, it then attempts to find a SCP-like URL. And if that cannot be found, it assumes rawurl is a local path. If none of these rules apply, Parse returns an error.

Example:

package main

import (
	"fmt"

	url "github.com/whilp/git-urls"
)

func main() {
	http, err := url.Parse("https://github.com/hello/hello.git")
	if err != nil {
		panic(err)
	}

	ssh, err := url.Parse("git@github.com:hello/hello.git")
	if err != nil {
		panic(err)
	}

	fmt.Printf("http: %s\n", http.Path)
	fmt.Printf("ssh: %s\n", ssh.Path)
}

returns:

http: /hello/hello.git
ssh: hello/hello.git

Fixes #397

[Hunter-Thompson]

Im not sure how to add a new fixture for this test, can someone help me out with that?

[Hunter-Thompson]

@mcuadros, can you review? This is quite a big bug.

[Hunter-Thompson]

@mcuadros bump

[Harishkrishna17]

@mcuadros Any update here ?

[Hunter-Thompson]

Here's an upstream fork that people can use until this is merged.

https://github.com/smallcase/go-git

v5.4.3

[alexec]

I've review the changes in this PR:

• The licence of the lib it MIT.
• This supports the git URL format.
• Does it need a test?

[tcolgate]

FWIW, this fix (as present in hte argo fork, doesn't seem to work for me), I thin it is passing the wrong URL on to github...

2022/04/12 09:21:23 err cloning, pkt-line 1: invalid hash text: encoding/hex: invalid byte: U+0052 'R' (ERR 
  myorg/myrepo.git/myorg/mysubrepo is not a valid repository name
  Visit https://support.github.com/ for help)

[tcolgate]

For submodules specified with an absolute URL this is also needed...
argoproj-labs#3

[mattbucci]

This was patched in the Digital Ocean fork here: digitalocean#5