Generate Bindata iff TAGS="bindata" and not up-to-date

[zeripath]

• Ensure build tags are passed to go generate
• Move bindata go:generate to files that require build bindata
• Remove duplicate main.go and move to single script in scripts
• Add hash of fileinfo checking to bindata files

[zeripath]

This should not be skip-changelog as the build command is changed - and users who use go generate instead of make may need to change how they generate.

[codecov-io]

Codecov Report

Merging #10004 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #10004      +/-   ##
==========================================
+ Coverage   42.26%   42.27%   +<.01%     
==========================================
  Files         610      610              
  Lines       80372    80372              
==========================================
+ Hits        33966    33974       +8     
+ Misses      42228    42220       -8     
  Partials     4178     4178

Impacted Files	Coverage Δ
models/repo_sign.go	36.2% <0%> (ø)	⬆️
models/pull_sign.go	34.86% <0%> (ø)	⬆️
models/repo.go	49.66% <0%> (-0.14%)	⬇️
services/pull/patch.go	67.92% <0%> (ø)	⬆️
models/pull.go	43.49% <0%> (+0.58%)	⬆️
modules/log/event.go	65.64% <0%> (+1.02%)	⬆️
models/unit.go	39.5% <0%> (+2.46%)	⬆️
services/pull/temp_repo.go	34.18% <0%> (+2.56%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c930141...ee57d80. Read the comment docs.

[6543]

without

real    0m19,695s
user    0m9,189s
sys     0m5,747s

with patch

real    0m14,875s
user    0m4,250s
sys     0m4,771s

[6543]

where is the benchmark CI task ;)

[6543]

nice refactor ... the time imprufement is not that mouch for me ...

[6543]

@zeripath can you make needsUpdate to hash files in paralel ?

[zeripath]

The order is important in SHA hashes. I guess we could generate a list and sort it at the end?

If you want to see the biggest improvement repeatedly build without tags=bindata as currently we enforce building it even if you don't want it.

There's another side effect here - some small machines have problems building bindata so without the earliest part of this pr they won't be able to build.

[guillep2k]

Sorry I couldn't see this earlier.

Just a couple of nits, but otherwise LGTM.

[guillep2k]

So, we're basically doing make's job. 😆

[zeripath]

Yup. That's what you get when you mix two competing build systems ...